Add support for X509_get0_pubkey #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
x509-pubkey
branch
2 times, most recently
from
987269a to
8aca04c
Compare
skmcgrail
previously approved these changes
May 8, 2023
andrewhop
previously approved these changes
May 9, 2023
samuel40791765
force-pushed
the
x509-pubkey
branch
2 times, most recently
from
3d9fdb8 to
bfe46bd
Compare
samuel40791765
force-pushed
the
x509-pubkey
branch
from
bfe46bd to
f27b247
Compare
samuel40791765
force-pushed
the
x509-pubkey
branch
from
f27b247 to
fd134e2
Compare
skmcgrail
approved these changes
May 10, 2023
andrewhop
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
CryptoAlg-1725Description of changes:
mySQL consumes the
X509_get0_pubkeyAPI when building with OpenSSL1.1.1/AWS-LC, and uses theX509_get_pubkeywhen built with OpenSSL1.0.2.X509_get0_pubkeyseems to have been added in OpenSSL1.1.1 and is very similar toX509_get_pubkey(which exists in AWS-LC).X509_get_pubkeyattempts to decode the public key for certificate x. If successful it returns the public key as anEVP_PKEY pointerwith its reference count incremented: this means the returned key must be freed up after use.X509_get0_pubkeyis similar except it does not increment the reference count of the returnedEVP_PKEYso it must not be freed up after use.Call-outs:
N/A
Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.